Review Request 122987: Allow user to specify path to myspell dictionary files

[Eugene Shalygin]

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
> > src/plugins/hunspell/CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7>
> >
> >     So you change an hardcoded path by a user chosen hardcoded one ?
> >     
> >     looking at the hunspell -D output, it looks like hunspell looks in more than one directory.
> >     
> >     hunspell -D
> >     
> >     [cut]
> >     
> >     AVAILABLE DICTIONARIES (path is not mandatory for -d option):
> >     /usr/share/hunspell/fr_FR
> >     /usr/share/hunspell/fr
> >     /usr/share/hunspell/en_US
> >     /usr/share/myspell/fr_FR
> >     /usr/share/myspell/hyph_en_US
> >     /usr/share/myspell/hyph_fr
> >     /usr/share/myspell/fr
> >     /usr/share/myspell/hyph_fr_FR
> >     /usr/share/myspell/en_US
> >     LOADED DICTIONARY:
> >     /usr/share/hunspell/fr_FR.aff
> >     /usr/share/hunspell/fr_FR.dic

On my system all dictionary files outside of /usr/share/hunspell/ are symlinks to files in this directory. Do you think it would be better to use (existent?) directories from 'SEARCH PATH:' section of hunspell -D output?


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
-----------------------------------------------------------


On Березень 17, 2015, 2:09 після полудня, Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated Березень 17, 2015, 2:09 після полудня)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150317/1b51dfd2/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel