Review Request 122812: Fix BIC introduced in kdelibs 4

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122812/#review77046
-----------------------------------------------------------

Ship it!


Looks good.

Also as for how to deal with kdelibs being broken:
I would suggest to simply release 4.14.6.1 as a hotfix release with only this change (could be as trivial as repacking the tarball with the patch applied). Albert, would you be so kind? :)

Short of a hotfix release I guess informing packagers is the next best thing we can do at this point.

- Harald Sitter


On March 4, 2015, 5:26 p.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122812/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 5:26 p.m.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> First of all sorry for that!
> In commit c2046dd7064634d4d6ba50cafd8b1047bd133859 I introduced a BIC by renaming public DOMString::trimSpaces() to DOMString::parsedUrl().
> However AFICT trimSpaces() was only used internally by khtml.
> I can either revert the commit or apply this patch that reinstate old DOMString::trimSpaces() and mark it as deprecated.
> 
> 
> Diffs
> -----
> 
>   khtml/dom/dom_string.h 087f697 
>   khtml/dom/dom_string.cpp a3c4abd 
> 
> Diff: https://git.reviewboard.kde.org/r/122812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150305/6bd5acd4/attachment.htm>