<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122812/">https://git.reviewboard.kde.org/r/122812/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also as for how to deal with kdelibs being broken:
I would suggest to simply release 4.14.6.1 as a hotfix release with only this change (could be as trivial as repacking the tarball with the patch applied). Albert, would you be so kind? :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Short of a hotfix release I guess informing packagers is the next best thing we can do at this point.</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On March 4th, 2015, 5:26 p.m. UTC, Andrea Iacovitti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and Albert Astals Cid.</div>
<div>By Andrea Iacovitti.</div>
<p style="color: grey;"><i>Updated March 4, 2015, 5:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all sorry for that!
In commit c2046dd7064634d4d6ba50cafd8b1047bd133859 I introduced a BIC by renaming public DOMString::trimSpaces() to DOMString::parsedUrl().
However AFICT trimSpaces() was only used internally by khtml.
I can either revert the commit or apply this patch that reinstate old DOMString::trimSpaces() and mark it as deprecated.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/dom/dom_string.h <span style="color: grey">(087f697)</span></li>
<li>khtml/dom/dom_string.cpp <span style="color: grey">(a3c4abd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122812/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>