Review Request 122812: Fix BIC introduced in kdelibs 4

Andrea Iacovitti aiacovitti at
Wed Mar 4 17:26:04 GMT 2015

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Albert Astals Cid.

Repository: kdelibs


First of all sorry for that!
In commit c2046dd7064634d4d6ba50cafd8b1047bd133859 I introduced a BIC by renaming public DOMString::trimSpaces() to DOMString::parsedUrl().
However AFICT trimSpaces() was only used internally by khtml.
I can either revert the commit or apply this patch that reinstate old DOMString::trimSpaces() and mark it as deprecated.


  khtml/dom/dom_string.h 087f697 
  khtml/dom/dom_string.cpp a3c4abd 




Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list