Review Request 121930: [OS X] improvements to KSharedData

René J.V. Bertin rjvbertin at
Fri Jan 9 15:25:21 GMT 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 9, 2015, 3:25 p.m.)


This change has been marked as submitted.

Review request for KDE Software on Mac OS X, kdelibs and Allen Winter.

Repository: kdelibs


This patch improves KSharedData on 2 points:

- It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't know why this was deactivated explicitly on OS X (do you remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now.

- OS X doesn't have `posix_fallocate()`, but an emulation of this function is available in the Mozilla code (reference found on StackOverflow). The code seems to be license-compatible, so I removed the code for non-OS X platforms, and include it in `kshareddatacache_p.h`. Again, this seems to work.


  kdecore/util/kshareddatacache_p.h 931de4d 
  kdecore/util/posix_fallocate_mac.h PRE-CREATION 



On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default MUA).


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list