Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros

Jaime Torres Amate jtamate at gmail.com
Thu Jan 8 20:39:04 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121935/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kactivities


Description
-------

I've been unable to compile frameworks since I added the folowing options to kdesrc-buildrc

-Wall -Wformat -Werror=format-security -Werror=return-type -Wno-variadic-macros -Wlogical-op


Diffs
-----

  src/imports/resourcemodel.cpp ffdf571 
  src/service/plugins/sqlite/ResourceLinking.cpp be55ff5 
  src/workspace/settings/MainConfigurationWidget.cpp e130d1d 

Diff: https://git.reviewboard.kde.org/r/121935/diff/


Testing
-------

It compiles with gcc 4.9 and clang++ (without those flags)


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150108/d618a1fc/attachment.htm>


More information about the kde-core-devel mailing list