[Development] Please help me get my pending review count down

[Christoph Cullmann]

Hi,

is one of the problems the misuse of QDBus in KUniqueApplication before the actual QApplication is constructed?

Would it be possible to just create in that case a temporary QCoreApplication on the stack in KUniqueApplication::start?

Kate had similar "I get stuck" problems until the QApplication was correctly constructed in all cases before the first QDBus use.

Greetings
Christoph

----- Ursprüngliche Mail -----
> On Wednesday, July 29, 2015 11:03:15 AM Martin Klapetek wrote:
> > On Wed, Jul 29, 2015 at 11:47 AM, Marc Mutz <marc.mutz at kdab.com> wrote:
> > > On Wednesday 29 July 2015 09:04:42 Martin Klapetek wrote:
> > > > Can you perhaps create a single diff against 5.5/dev/master
> > > > which could be easily applied? That should make things
> > > > much easier to help :)
> > > 
> > > Assuming you're talking about the dbus changes, wouldn't you actually
> > > want
> > > to
> > > cherry-pick them one by one and see which one breaks?
> > 
> > Perhaps that should be done as well, yes, although Thiago requested the
> > /whole set of changes/ to be tested:
> > 
> > I need someone to take the whole set of changes, apply to their Qt 5.5
> > build
> > > and test KF5-powered applications to see what gets broken and why. Please
> > > provide patches to either QtDBus, KF5 or the applications.
> > 
> > Which would be much simpler with a single diff.
> 
> Gerrit gives you a git command to copy'n'paste and you can pull the changeset
> and test it. That's much better than manually applying some plaintext diff.
> 
> Bye
> --
> Milian Wolff | milian.wolff at kdab.com | Software Engineer
> KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
> Tel: +49-30-521325470
> KDAB - The Qt Experts

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234