Review Request 120282: Fix use of qgetenv in kshorturifilter

Maximiliano Curia maxy at debian.org
Fri Sep 26 22:00:01 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120282/
-----------------------------------------------------------

(Updated Sept. 26, 2014, 9 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Runtime.


Repository: kde-runtime


Description
-------

This is probably a leftover from the replacement of getenv with qgetenv. The
current code uses the const char * cast of QByteArray which then is destroyed
leaving an invalid pointer.


Diffs
-----

  kurifilter-plugins/shorturi/kshorturifilter.cpp 6ba79e7437b5477f9e19a1aa3fa9cf71ac60ba1b 

Diff: https://git.reviewboard.kde.org/r/120282/diff/


Testing
-------

This patch is included in the Debian packages since 22-01-2014


Thanks,

Maximiliano Curia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140926/b589b6b3/attachment.htm>


More information about the kde-core-devel mailing list