Review Request 120282: Fix use of qgetenv in kshorturifilter

Lukáš Tinkl lukas at kde.org
Fri Sep 19 13:06:57 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120282/#review66948
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Zář. 19, 2014, 1:31 odp., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120282/
> -----------------------------------------------------------
> 
> (Updated Zář. 19, 2014, 1:31 odp.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This is probably a leftover from the replacement of getenv with qgetenv. The
> current code uses the const char * cast of QByteArray which then is destroyed
> leaving an invalid pointer.
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 6ba79e7437b5477f9e19a1aa3fa9cf71ac60ba1b 
> 
> Diff: https://git.reviewboard.kde.org/r/120282/diff/
> 
> 
> Testing
> -------
> 
> This patch is included in the Debian packages since 22-01-2014
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140919/8a03d08f/attachment.htm>


More information about the kde-core-devel mailing list