Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

[Dawit Alemayehu]

> On Sept. 17, 2014, 7:49 p.m., David Faure wrote:
> > I like this patch :-)
> > 
> > Well, maybe we could even get rid of the fsType checks?

I was going to suggest the same thing. For our purposes here, we do not care if the filesystem type is identified. We only care about whether or not the stat'ing the directory succeeded. I will remove that call.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66775
-----------------------------------------------------------


On Sept. 17, 2014, 12:55 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120182/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 12:55 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 336529
>     http://bugs.kde.org/show_bug.cgi?id=336529
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch stops KIO::CopyJob from querying for free disk space when the filesystem type is unknown.
> 
> 
> Diffs
> -----
> 
>   kio/kio/copyjob.cpp 713255b 
> 
> Diff: https://git.reviewboard.kde.org/r/120182/diff/
> 
> 
> Testing
> -------
> 
> Mounted Andriod filesystem through sshfs and attempted to copy files through sftp.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140918/37bc2c5f/attachment.htm>