Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

David Faure faure at kde.org
Wed Sep 17 20:49:22 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66775
-----------------------------------------------------------

Ship it!


I like this patch :-)

Well, maybe we could even get rid of the fsType checks?

- David Faure


On Sept. 17, 2014, 12:55 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120182/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 12:55 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 336529
>     http://bugs.kde.org/show_bug.cgi?id=336529
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch stops KIO::CopyJob from querying for free disk space when the filesystem type is unknown.
> 
> 
> Diffs
> -----
> 
>   kio/kio/copyjob.cpp 713255b 
> 
> Diff: https://git.reviewboard.kde.org/r/120182/diff/
> 
> 
> Testing
> -------
> 
> Mounted Andriod filesystem through sshfs and attempted to copy files through sftp.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140917/d184a7f3/attachment.htm>


More information about the kde-core-devel mailing list