Using Gerrit for code review in KDE

[Martin Gräßlin]

On Saturday 13 September 2014 16:51:15 Albert Astals Cid wrote:
> El Divendres, 12 de setembre de 2014, a les 22:52:40, Marco Martin va
> 
> escriure:
> > On Tuesday, September 9, 2014, Jan Kundrát <jkt at flaska.net> wrote:
> > > If you would like all plasma to go, just give me a list of repos and I
> > 
> > can make it happen.
> > 
> > No, definitely not yet
> > 
> > > In my opinion, the purpose of this test is not to verify that Gerrit
> > 
> > works or that the ACLs are set up properly -- both were done already.
> > 
> > As part of the experiment i would also like to try to have stricter acls
> > for +2 and submit, like starting from mantainers then slowly adding people
> > (that's also how i understood it would have worked during the bof)
> 
> I'd read that as being against the KDE Manifesto.

my understanding was that it's still possible to bypass the code review, so I 
cannot see that it's against the KDE Manifesto as it's only a kind of social 
contract. Or am I missing something.

Personally I like the idea of having the +2 limited to the devs familiar with 
the code.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140913/6cfade05/attachment.sig>