Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

[Frank Schütte]

> On Okt. 28, 2014, 2:59 nachm., Thomas Lübking wrote:
> > solid-device-automounter/kded/DeviceAutomounter.cpp, line 76
> > <https://git.reviewboard.kde.org/r/120839/diff/1/?file=322442#file322442line76>
> >
> >     unrelated to this patch, but i'd like to raise:
> >     
> >     "wtf does the function that apparently performs an automount impact the "lastSeen" state before?" sa->isAccessible() should be false right now, so doesn't this entirely defeat the idea of "lastSeen"?

Hi,
I looked closer and to me it makes sense. LastSeenMounted is set to false before the mount operation is attempted. During the mount process the method mountChanged changes LastSeenMounted to true. So, that makes sense to me.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120839/#review69293
-----------------------------------------------------------


On Okt. 28, 2014, 7:50 nachm., Frank Schütte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120839/
> -----------------------------------------------------------
> 
> (Updated Okt. 28, 2014, 7:50 nachm.)
> 
> 
> Review request for kdelibs, Solid and Christoph Feck.
> 
> 
> Bugs: 243046 and 261376
>     http://bugs.kde.org/show_bug.cgi?id=243046
>     http://bugs.kde.org/show_bug.cgi?id=261376
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Hi Christoph,
> solid-device-automounter fails to automount unknown devices, even if it is checked,
> because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
> So this patch corrects the logic to at first evaluate shouldAutomountDevice.
> Inside this evaluation automountUnknownDevices is evaluated correctly.
> Please review this patch. Christoph Feck urged me to submit this patch.
> It took me quite a while to figure it out, though.
> Bye,
> Frank
> 
> 
> Diffs
> -----
> 
>   solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 
>   solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be 
> 
> Diff: https://git.reviewboard.kde.org/r/120839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank Schütte
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141028/3208790c/attachment.htm>