Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

Frank Schütte fschuett at
Tue Oct 28 19:50:05 GMT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Okt. 28, 2014, 7:50 nachm.)

Review request for kdelibs, Solid and Christoph Feck.


Fixed whitespace issues raised by Thomas Lübking

Bugs: 243046 and 261376

Repository: kde-runtime


Hi Christoph,
solid-device-automounter fails to automount unknown devices, even if it is checked,
because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
So this patch corrects the logic to at first evaluate shouldAutomountDevice.
Inside this evaluation automountUnknownDevices is evaluated correctly.
Please review this patch. Christoph Feck urged me to submit this patch.
It took me quite a while to figure it out, though.

Diffs (updated)

  solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 
  solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be 




Frank Schütte

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list