SDDM-KCM In Review

Vishesh Handa me at
Wed Oct 15 13:07:57 BST 2014

Hey David.

None of these are blockers. Just stuff I noticed.

* There is this strange ACKNOWLEDGEMENTS file

* themeconfig.cpp
** The delegate seems to have a fixed size of 128x128. This might not be
ideal for hidpi screens
** ThemeConfig::dump - Extra indendation

* thememodel.cpp - KStandardDirs and KGlobal headers are not required
* usersmodel.cpp - The coding style is quite different
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list