SDDM-KCM In Review
me at vhanda.in
Wed Oct 15 13:07:57 BST 2014
None of these are blockers. Just stuff I noticed.
* There is this strange ACKNOWLEDGEMENTS file
** The delegate seems to have a fixed size of 128x128. This might not be
ideal for hidpi screens
** ThemeConfig::dump - Extra indendation
* thememodel.cpp - KStandardDirs and KGlobal headers are not required
* usersmodel.cpp - The coding style is quite different
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-core-devel