SDDM-KCM In Review

[Albert Astals Cid]

El Dissabte, 4 d'octubre de 2014, a les 22:38:30, David Edmundson va escriure:
> Hey all,
> 
> I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now
> starting the mandatory review period.
> 
> It's a config module for configuring SDDM, the Display Manager. Mostly
> themes and autologin, plus some misc options.

You do have a KAboutData in src/sddmkcm.cpp you do nothing with and also leak.

There is no COPYING file (not sure if this one is mandatory or not, ask 
Riddell)

The README looks outdated to me.

The qml file doesn't have a copyright header.

Cheers,
  Albert

> 
> The final destination will be workspace.
> 
> Application history:
>  - I wrote a KCM for LightDM in Playground
>  - This was forked and changed to work on SDDM in Github
>  - We switched to SDDM as the recommended DM for Plasma
>  - We want a KCM to configure it
>  - It's easier (for translations especially) if we put the KCM back our
> repos
>  - Upstream are happy for this to happen [1]
> 
> David
> 
> [1] https://projects.kde.org/projects/kdereview/sddm-kcm
> [2] https://github.com/sddm/sddm-kcm/issues/14