Review Request for KDecoration

[Sebastian Kügler]

On Friday, November 28, 2014 14:16:38 Martin Gräßlin wrote:
> On Friday 28 November 2014 13:53:07 Sebastian Kügler wrote:
> > On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote:
> > > 
> > > The documentation is copied from Plasma. I don't know anything about
> > > high
> > > DPI,  so maybe sebas can answer that.
> >
> > Context?
> 
> the context is High-DPI in particular the gridUnit which I also introduced
> in  KDecoration2 with exactly the same documentation. Verbatim quote:
>     /**
>      * The fundamental unit of space that should be used for sizes,
> expressed  in pixels.
>      * Given the screen has an accurate DPI settings, it corresponds to a 
> millimeter
>      */
>     Q_PROPERTY(int gridUnit READ gridUnit NOTIFY gridUnitChanged)

Ah, right. int is used here to prevent sub-pixel alignment problems. We always 
want to align stuff at full pixels.

Does this clarify?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9