Review Request 120154: Equal entries implies existing directory

[David Faure]

> On Nov. 23, 2014, 4:46 p.m., Luigi Toscano wrote:
> > Which branch has the patch been submitted to?

I was just cleaning up something that had already been committed.

dd160dee7c3f68aa49ad1868d87db61d69d10334 in kio master
bf0a8b445afe6caed0e89f7fcf5cda7d63d2ccf8 in kdelibs KDE/4.14


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120154/#review70820
-----------------------------------------------------------


On Nov. 23, 2014, 4:36 p.m., Jan-Marek Glogowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120154/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 4:36 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Equal entries implies existing directory
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b3fabe83ae 
> 
> Diff: https://git.reviewboard.kde.org/r/120154/diff/
> 
> 
> Testing
> -------
> 
> Equal entries implies existing directory
> 
> The equal file error should take precedence over the existing
> directory error, as this implies exist.
> 
> This actually prevents a data loss on case-insensitive file systems
> like CIFS, where renaming a directory from 'Test' to 'test' actually
> removes the single directory (both have the same inode).
> 
> 
> Thanks,
> 
> Jan-Marek Glogowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141123/b7d2ba9e/attachment.htm>