Review Request 118091: Changed formatting to fit the KDE Coding Standard

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118091/#review57743
-----------------------------------------------------------


changing the coding style would completely break the already started port to xcb and thus Qt5, see https://git.reviewboard.kde.org/r/114178/

- Martin Gräßlin


On May 12, 2014, 3:36 a.m., Uzair Shamim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118091/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 3:36 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> Certain parts of the code did not follow the kde code guideline and while I know it is not mandatory to follow the guide lines, but I felt I should fix it. There were certain parts I was unsure about so I left them as they were. Most of the changes are just with brace placement.
> 
> KDE Coding Standard: http://techbase.kde.org/Policies/Kdelibs_Coding_Style
> 
> 
> Diffs
> -----
> 
>   kbackgroundsnapshot.cpp 9d81ba1 
>   kipiimagecollectionselector.h 10afedc 
>   kipiimagecollectionselector.cpp 5fe09d8 
>   kipiinterface.h 1c18039 
>   ksnapshot.cpp 0d8e996 
>   ksnapshotimagecollectionshared.cpp 8ef1b0e 
>   ksnapshotinfoshared.cpp 0e0d840 
>   ksnapshotobject.cpp 608f7dc 
>   ksnapshotpreview.cpp db4fd10 
>   main.cpp 4b4f097 
>   regiongrabber.cpp fb038a3 
>   snapshottimer.cpp 843f06d 
>   windowgrabber.cpp 21a9531 
> 
> Diff: https://git.reviewboard.kde.org/r/118091/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine, seems to take screenshots just like before. As I said, 99% of the changes are just brace placement.
> 
> 
> Thanks,
> 
> Uzair Shamim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140512/7db482c7/attachment.htm>