Review Request 113969: Do not assume every items have the same height

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113969/#review57618
-----------------------------------------------------------


This review has been submitted with commit e132310135b2d87cbcda7e82883453d6e1093c6a by Weng Xuetian on behalf of Yichao Yu to branch KDE/4.13.

- Commit Hook


On April 22, 2014, 10:13 a.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113969/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 10:13 a.m.)
> 
> 
> Review request for kdelibs, David Faure, Rafael Fernández López, and Michael Pyne.
> 
> 
> Bugs: 309780
>     http://bugs.kde.org/show_bug.cgi?id=309780
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> 1. the offset addjust in `KCategorizedView::indexAt` was a no-op (it operates on a temporary variable and is not needed).
> 2. KCategorizedView::indexAt (effectively) assumes all items has the same height when doing bsearch and therefore failed to handle some cases when the text takes multiple lines as shown in the bug report.
> 
> This patch removes the no-op and add special check for items in the same row on the left (or on the right for RightToLeft layout) in order to determine which way the bsearch should go.
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kcategorizedview.cpp be811aa 
> 
> Diff: https://git.reviewboard.kde.org/r/113969/diff/
> 
> 
> Testing
> -------
> 
> Compiles and fixes the problem.
> Tested with systemsettings in the following conditions:
> 1. single row in each category.
> 2. multiple rows in each category.
> 3. scrollbar not at the top.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140508/00ad077c/attachment.htm>