Review Request 117157: Unlock session via DBus
Kirill Elagin
kirelagin at gmail.com
Sat Mar 29 12:05:25 GMT 2014
> On March 29, 2014, 12:02 p.m., Thomas Lübking wrote:
> > what is the valid (read: not malicious) usecase for this?
> >
> > i'd rather say that if quitting the greeter to exit the lock w/o password, that should be fixed to *not* exit the lock w/o password provision.
There are some usecases mentioned in the bug I referenced.
I can add another one: imagine that you are hosting, say, a programming competition (like ACM ICPC). You've got a room of PCs, they are locked before the contest.
When the contest starts you want to unlock them all simultaneously instead of having contestants enter passwords by hands.
- Kirill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117157/#review54536
-----------------------------------------------------------
On March 29, 2014, 11:58 a.m., Kirill Elagin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117157/
> -----------------------------------------------------------
>
> (Updated March 29, 2014, 11:58 a.m.)
>
>
> Review request for kde-workspace.
>
>
> Bugs: 314989
> http://bugs.kde.org/show_bug.cgi?id=314989
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Unlock session via DBus
>
> Make org.freedesktop.ScreenSaver.SetActive(false) unlock session.
>
>
> Diffs
> -----
>
> plasma-workspace/ksmserver/screenlocker/interface.cpp ecb30a37b1a207cf9dab8c53b1b879108a99a45b
> plasma-workspace/ksmserver/screenlocker/ksldapp.h b292b62f4df073fff31bcbfd0e39f4c4fe04c92d
> plasma-workspace/ksmserver/screenlocker/ksldapp.cpp f2e5262524447e8ae1df1fbf6543297c3be3e6b8
>
> Diff: https://git.reviewboard.kde.org/r/117157/diff/
>
>
> Testing
> -------
>
> I've tested this with KDE 4.11.5 which I'm currently running.
> Rebasing to master was completely trivial; I've looked through the code and I believe all the assumptions I made are still valid in master.
>
>
> Thanks,
>
> Kirill Elagin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140329/0c6a638a/attachment.htm>
More information about the kde-core-devel
mailing list