Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116524/#review52715
-----------------------------------------------------------



kioslave/ftp/ftp.cpp
<https://git.reviewboard.kde.org/r/116524/#comment37182>

    Given that m_currentPath might not end with a '/' (as indicated by the if statement 2 lines below), this is buggy.
    
    m_currentPath="/home/adawit/dev"
    path="/home/adawit/development"
    Let's assume both dirs exist.
    ++pos and path.mid(pos) will lead to "lopment".
    
    You should make a local slash-terminated copy of m_currentPath before calling startsWith().


- David Faure


On March 7, 2014, 6:48 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116524/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 6:48 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 326292
>     http://bugs.kde.org/show_bug.cgi?id=326292
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch changes Ftp::ftpSize such that it has support for servers that do not allow absolute paths with the SIZE command. That means when sending the command "SIZE /somefile" fails, it will try sending "SIZE somefile" before giving up. See bug report for details.
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/ftp.cpp ddc6eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/116524/diff/
> 
> 
> Testing
> -------
> 
> Installed Ftp server from bug report on an Android device and run tests.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140312/396b9ea4/attachment.htm>