Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

Dawit Alemayehu adawit at kde.org
Fri Mar 7 06:48:31 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116524/
-----------------------------------------------------------

(Updated March 7, 2014, 6:48 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

Updated patch:

- Try to always do SIZE requests using relative paths.
- Removed changes a related bug report from this patch.


Bugs: 326292
    http://bugs.kde.org/show_bug.cgi?id=326292


Repository: kdelibs


Description
-------

This patch changes Ftp::ftpSize such that it has support for servers that do not allow absolute paths with the SIZE command. That means when sending the command "SIZE /somefile" fails, it will try sending "SIZE somefile" before giving up. See bug report for details.


Diffs (updated)
-----

  kioslave/ftp/ftp.cpp ddc6eaf 

Diff: https://git.reviewboard.kde.org/r/116524/diff/


Testing
-------

Installed Ftp server from bug report on an Android device and run tests.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140307/04a7e5bf/attachment.htm>


More information about the kde-core-devel mailing list