Review Request 116602: fix setting "ssl_was_in_use" metadata

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review51990
-----------------------------------------------------------



kio/kio/job.cpp
<https://git.reviewboard.kde.org/r/116602/#comment36943>

    Shouldn't this test be isEmpty() instead



kio/kio/job.cpp
<https://git.reviewboard.kde.org/r/116602/#comment36944>

    Couldn't the if statement not be simplified into
    
    d->m_outgoingMetaData[QLatin1String("ssl_was_in_use")] = sslInUse.isEmpty() ? QLatin1String("FALSE") : sslInUse;


- Dawit Alemayehu


On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 9:43 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified this happen) using [] operator results in inserting a new item with key "ssl_in_use" and NullString value in incomingMetaData map and, as a consequence, a new item with key "ssl_was_in_use" and NullString value in outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using queryMetadata().
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.cpp edc5fed 
> 
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140304/ff6b8926/attachment.htm>