Review Request 116602: fix setting "ssl_was_in_use" metadata

Andrea Iacovitti aiacovitti at libero.it
Tue Mar 4 21:43:49 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/
-----------------------------------------------------------

Review request for kdelibs and Dawit Alemayehu.


Repository: kdelibs


Description
-------

If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified this happen) using [] operator results in inserting a new item with key "ssl_in_use" and NullString value in incomingMetaData map and, as a consequence, a new item with key "ssl_was_in_use" and NullString value in outgoingMetaData map.
This patch aims to avoid this situation by looking up the key using queryMetadata().


Diffs
-----

  kio/kio/job.cpp edc5fed 

Diff: https://git.reviewboard.kde.org/r/116602/diff/


Testing
-------


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140304/046bc6d2/attachment.htm>


More information about the kde-core-devel mailing list