Review Request 116117: Place new panels to bottom by default

Jan Grulich jgrulich at redhat.com
Tue Mar 4 17:07:34 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/
-----------------------------------------------------------

(Updated March 4, 2014, 5:07 p.m.)


Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K├╝gler.


Changes
-------

It looks that previous script didn't work correctly, because I always assumed when there is some panel, it's placed to bottom. Now I'm checking free edges and placing a new panel according to which one is free.


Repository: kde-workspace


Description
-------

When adding a new empty panel, it's placed at top by default, but it should be placed to bottom, when it's possible. Also when adding a new "Default Panel" to second screen without any panel and you already have one on your first screen, then it's also placed to top instead of bottom. This is just a simple fix, which changes order of checking free edges for empty panels and adds a check for screenId when executing a script for default panel layout. I'm not much sure with the javascript part, but it works.


Diffs (updated)
-----

  plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 356e689 

Diff: https://git.reviewboard.kde.org/r/116117/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140304/2616858d/attachment.htm>


More information about the kde-core-devel mailing list