Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

[Eike Hein]

> On July 5, 2014, 1:51 p.m., Mark Gaiser wrote:
> > Last question, could you make a unittest for this?
> > 
> > I'm not quite sure if it's even possible since this is in a private class. You might be able to test this using KNewFileMenu::checkUpToDate?
> > KIO has very few unittests for KNewFileMenu, they can be found in knewfilemenutest.cpp. More is welcome there.

No clue to be honest since the operation relies on template files being installed, which aren't in the same framework (the templates are part of the libkonq codebase in kde-baseapps ...). I'm not experienced with writing KIO-related unit tests so I'd likely need help there, and I'd strongly advice against waiting for it right now (my todo is large and frightning).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/#review61649
-----------------------------------------------------------


On July 5, 2014, 1:26 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119130/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 1:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KNewFileMenu was incorrectly ported to QStandardPaths, listing directories where it actually wants to collect template files within them. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knewfilemenu.cpp 4f1ca10 
> 
> Diff: https://git.reviewboard.kde.org/r/119130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140705/beb24498/attachment.htm>