Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/#review61649
-----------------------------------------------------------


Last question, could you make a unittest for this?

I'm not quite sure if it's even possible since this is in a private class. You might be able to test this using KNewFileMenu::checkUpToDate?
KIO has very few unittests for KNewFileMenu, they can be found in knewfilemenutest.cpp. More is welcome there.

- Mark Gaiser


On jul 5, 2014, 1:26 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119130/
> -----------------------------------------------------------
> 
> (Updated jul 5, 2014, 1:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KNewFileMenu was incorrectly ported to QStandardPaths, listing directories where it actually wants to collect template files within them. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/knewfilemenu.cpp 4f1ca10 
> 
> Diff: https://git.reviewboard.kde.org/r/119130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140705/58efdf09/attachment.htm>