Review Request 114956: Add support for getting a samba share's total size and free space through KIO

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114956/#review48175
-----------------------------------------------------------

Ship it!


For KDE 4.x, a "special" command is the only way, so IMHO this can go in.

At the same time, it would indeed be nice to write a proper Job class for this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync API. This is like QFile (sync) and KIO::get (async)). This requires a new virtual method in SlaveBase, which is why it can't go into 4.x.

- David Faure


On Jan. 10, 2014, 6:07 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114956/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 6:07 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command, which will be used in dolphin's statusbar to show the free space.
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: https://git.reviewboard.kde.org/r/114956/diff/
> 
> 
> Testing
> -------
> 
> I have written the code to implement it in dolphin, where it seems to work fine.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140124/dffa884f/attachment.htm>