Review Request 114956: Add support for getting a samba share's total size and free space through KIO

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114956/#review47184
-----------------------------------------------------------


As I already said in the Dolphin request https://git.reviewboard.kde.org/r/114957/ : I think there should be some API in KIO that applications can use to call this code (maybe KDiskFreeSpaceInfo could be extended to also handle smb?).

Forcing applications that want to know about the free space to shout the magic number "5" to the kioslave is IMHO a bad idea.

- Frank Reininghaus


On Jan. 10, 2014, 6:07 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114956/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 6:07 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command, which will be used in dolphin's statusbar to show the free space.
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: https://git.reviewboard.kde.org/r/114956/diff/
> 
> 
> Testing
> -------
> 
> I have written the code to implement it in dolphin, where it seems to work fine.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140111/3fe7eb1c/attachment.htm>