Review Request 115079: don't install dbus interface files in kglobalaccel

[Hrvoje Senjan]

> On Jan. 21, 2014, 1:16 p.m., Martin Gräßlin wrote:
> > I guess it's obvious from the matching review request for kgloballacel: I consider copying the files to every user as the wrong solution. In Qt terms I would give it a -2.
> 
> Thomas Lübking wrote:
>     esp. since that means to keep them sync'd all the time...
>     
>     again:
>     what is the problem about having a common data package dependency downstream?
>     (I've not much experience on distro packaging, so this is a serious question - even if it might sound dumb)

>what is the problem about having a common data package dependency downstream?
1) Some interfaces (*for now* only Klauncher's) are not 1:1 copies vs. kdelibs4
2) Distros (i can speak for openSUSE only) need to make build hosts prefer kdelibs4 XML's on kdelibs4 builds, and KF5 ones on KF5 builds, while at the same time make it completely irrelevant for the user which one is installed (i.e. one could/should be able to install either). Possible solution is that distros 'make' a stub package and copy xml by themselves, which is also not bulletproof when interfaces change, and is also quite ugly.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115079/#review47868
-----------------------------------------------------------


On Jan. 21, 2014, 12:48 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115079/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 12:48 p.m.)
> 
> 
> Review request for kde-workspace and Martin Gräßlin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> to go with https://git.reviewboard.kde.org/r/115078/ use local dbus interface files
> 
> 
> Diffs
> -----
> 
>   kcontrol/keys/org.kde.kglobalaccel.Component.xml PRE-CREATION 
>   kcontrol/keys/org.kde.KGlobalAccel.xml PRE-CREATION 
>   kcontrol/keys/CMakeLists.txt 072e614 
> 
> Diff: https://git.reviewboard.kde.org/r/115079/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140121/24f8455f/attachment.htm>