<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115079/">https://git.reviewboard.kde.org/r/115079/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 21st, 2014, 1:16 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess it's obvious from the matching review request for kgloballacel: I consider copying the files to every user as the wrong solution. In Qt terms I would give it a -2.</pre>
</blockquote>
<p>On January 21st, 2014, 1:29 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">esp. since that means to keep them sync'd all the time...
again:
what is the problem about having a common data package dependency downstream?
(I've not much experience on distro packaging, so this is a serious question - even if it might sound dumb)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>what is the problem about having a common data package dependency downstream?
1) Some interfaces (*for now* only Klauncher's) are not 1:1 copies vs. kdelibs4
2) Distros (i can speak for openSUSE only) need to make build hosts prefer kdelibs4 XML's on kdelibs4 builds, and KF5 ones on KF5 builds, while at the same time make it completely irrelevant for the user which one is installed (i.e. one could/should be able to install either). Possible solution is that distros 'make' a stub package and copy xml by themselves, which is also not bulletproof when interfaces change, and is also quite ugly.</pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On January 21st, 2014, 12:48 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Martin Gräßlin.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 12:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to go with https://git.reviewboard.kde.org/r/115078/ use local dbus interface files</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keys/org.kde.kglobalaccel.Component.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcontrol/keys/org.kde.KGlobalAccel.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcontrol/keys/CMakeLists.txt <span style="color: grey">(072e614)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115079/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>