Review Request 114623: kjs: Implement es6 Math.fround

[Martin Tobias Holmedahl Sandsmark]

> On Dec. 24, 2013, 1:13 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > what a silly function, but looks okay to me.
> 
> Aleix Pol Gonzalez wrote:
>     Shouldn't this go to KF5?
>     Also kdelibs is feature frozen...

yes, it should go into kf5 as well, but it was decided some time ago that missing implementations in kjs and khtml counted as bugs.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114623/#review46132
-----------------------------------------------------------


On Jan. 16, 2014, 5:56 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114623/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 5:56 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: Implement es6 Math.fround
> 
> 
> Diffs
> -----
> 
>   kjs/math_object.h 3d193dd 
>   kjs/math_object.cpp 89835e5 
> 
> Diff: https://git.reviewboard.kde.org/r/114623/diff/
> 
> 
> Testing
> -------
> 
> Basic Mozilla tests:
> 
> Math.fround(0)     // 0
> Math.fround(1)     // 1
> Math.fround(1.337) // 1.3370000123977661
> Math.fround(1.5)   // 1.5
> Math.fround(NaN)   // NaN
> Math.fround(Infinity)   // Inf
> Math.fround(-Infinity)   // -Inf
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140117/a40a7dd7/attachment.htm>