Why is kst in extragear without going through kdereview?

[Albert Astals Cid]

El Dilluns, 13 de gener de 2014, a les 16:53:01, Ben Cooksley va escriure:
> On Mon, Jan 13, 2014 at 2:28 PM, Albert Astals Cid <aacid at kde.org> wrote:
> > El Diumenge, 12 de gener de 2014, a les 15:47:40, Barth Netterfield va
> > 
> > escriure:
> >> On January 12, 2014 9:41:28 PM Albert Astals Cid wrote:
> >> > El Diumenge, 12 de gener de 2014, a les 15:32:16, Barth Netterfield va
> >> > 
> >> > escriure:
> >> > > On January 12, 2014 1:36:29 PM Albert Astals Cid wrote:
> >> > > > Hi there, can anyone explain how kst-plot ended up in extragear if
> >> > > > it
> >> > > > didn't go thorugh kdereview?
> >> > > > 
> >> > > > Or if it went thorugh kdereview why is there no email in k-c-d
> >> > > > about
> >> > > > it?
> >> > > > 
> >> > > > Cheers,
> >> > > > 
> >> > > >   Albert
> >> > > 
> >> > > What I know is covered in the discussions surrounding ticket FYQ-3736
> >> > 
> >> > I guess this is a sysadmin ticket which only you and sysadmins can't
> >> > access
> >> > so it doesn't really help much for the discussion :-)
> 
> Hi Albert,
> 
> > Ok, so from reading the log it seems sysadmin decided that since it was in
> > extragear back in the day it could still go there without review.
> > 
> > I think i disagree, but not sure we have a rule there. Opinions?
> 
> My apologies for the problem. I allowed it to enter extragear directly
> as I was under the misunderstanding that it's time outside of KDE
> repositories had been very short (more of a temporary change rather
> than a permanent one) - so the code itself was still in effect fully
> reviewed.
> 
> Unfortunately it appears I was incorrect, and the KST-Plot codebase
> had diverged from what was expected.
> 
> > Anyway what's done is done now and noone was hurt either go noone get sad
> > :-)
> > 
> > Only thing is that if it had went through review we would have found the
> > missing things (like l10n not being ready) at the proper review stage and
> > not with translators complaining because stuff in extragear is not good
> > enough.
> Sorry for the problems - I didn't expect that to happen.
> 
> > For those in these channel that still care about reviewing new stuff to
> > make sure it complies to our stabilished practices, know that kst-plot is
> > new and should be reviewed.
> 
> Should KST-Plot be sent to KDE Review, or is a call for review
> sufficient in this case?

I'd say the call for review should be enough.

Cheers,
  Albert

> 
> > Cheers all :-)
> > 
> > Albert
> 
> Thanks,
> Ben Cooksley
> KDE Sysadmin
> 
> >> Oh... sorry:  Here is the discussion.
> >> 
> >> -------------------------------------------------------------------------
> >> --
> >> 
> >> "Repository for kst" by netterfield
> >> Summary:
> >> 
> >> -kst was a part of extragear/graphics back in qt3/kde3 days.
> >> -it is now a pure qt4 or qt5 app (*)
> >> -we have been using svn.kde until recently. After a short meander over to
> >> github (**), the repository is now at
> >> git at git.kde.org:scratch/netterfield/kst- plot.
> >> -we would like to once again be part of kde.
> >> 
> >> Questions:
> >> -Is our old home of extragear/graphics the right place to go?
> >> extragear/science would be better, but it doesn't exist.
> >> -Can we move straight back to our old home of extragear/graphics, or
> >> should
> >> we need to do the path through playground and review?
> >> 
> >> * we are pure qt in order to make it easier for our growing number of
> >> windows and mac users.
> >> ** I was under the impression that pure qt apps could not be part of
> >> extragear and that we had to move. Albert and Eike have informed me that
> >> this is not true. So... we are back :-)
> >> 
> >> 1 Months Ago Administrators -- 11/24/13, 9:20 AM
> >> The repository and projects.kde.org entries have been set up at
> >> extragear/graphics, with the admin and description as you indicated.
> >> 
> >> Scripty will be adjusted automatically to retrieve the sources from the
> >> new
> >> locations once the initial push has been completed and the project admins
> >> have filled in the trunk and stable i18n branch information in Settings
> >> ->
> >> Repository for each project. Note that if you do not have a stable branch
> >> you should set none in the stable i18n branch and not master.
> >> 
> >> LXR and EBN will be adjusted automatically at their next run, which might
> >> take max a week.
> >> 
> >> The ReviewBoard entry will be set up by David after you have pushed and
> >> reopened this ticket.
> >> 
> >> Please note that you will need to run the "hooks enable" server-side
> >> command after the initial push to enable the email hooks and write
> >> access to non-repo- admins:
> >> http://community.kde.org/Sysadmin/GitKdeOrgManual#hooks-enable
> >> 
> >> You should also remove the sources from SVN after completing the push so
> >> scripty doesn't get confused by sources being found in two places at
> >> once.
> >> The customary way to do this is to initially replace the folder contents
> >> with a README file pointing at the new location, and then to remove the
> >> entire folder a few weeks later.
> >> 
> >> Also please note that git push --all does not push tags. git push --tags
> >> does. This is frequently forgotten. Both arguments cannot be used at the
> >> same time.
> >> 
> >> Please reopen this bug after the push has been completed.  IMPORTANT:
> >> please ensure the repository setting Enable development sites is enabled
> >> on KDE Projects in Settings -> Repository. Else no translations can be
> >> made.
> >> 
> >> Sayak Banerjee
> >> KDE Sysadmin
> >> 
> >> 1 Months Ago Administrators -- 12/2/13, 1:43 AM
> >> Please push the repository.
> >> 
> >> Thanks,
> >> Ben Cooksley
> >> KDE Sysadmin
> >> 
> >> 1 Months Ago dsolbach -- 12/2/13, 8:59 PM
> >> Reviewboard done. Please use one of the existing groups for reviews, or
> >> reopen if you need your own.
> >> 
> >> leaving ticket open for remaining work
> >> 
> >> 1 Months Ago netterfield -- 12/3/13, 11:11 PM
> >> I'm doing something wrong: Suggestions?
> >> 
> >> [cbn at ice kst]$ git remote add origin
> >> git at git.kde.org:projects/extragear/graphics/kst-plot
> >> [cbn at ice kst]$ git push --all origin
> >> FATAL: W any projects/extragear/graphics/kst-plot netterfield DENIED by
> >> fallthru
> >> (or you mis-spelled the reponame)
> >> fatal: Could not read from remote repository.
> >> 
> >> Please make sure you have the correct access rights
> >> and the repository exists.
> >> 
> >> 1 Months Ago Administrators -- 12/3/13, 11:43 PM
> >> You will find the repository located at kde:kst-plot (aka.
> >> git at git.kde.org:kst- plot).
> >> These access urls can also be found on the projects.kde.org page for
> >> kst-plot.
> >> 
> >> Thanks,
> >> Ben Cooksley
> >> KDE Sysadmin
> >> 
> >> 1 Months Ago netterfield -- 12/4/13, 8:23 PM
> >> I'm doing something wrong: Suggestions?
> >> 
> >> [cbn at ice kst]$ git remote add origin
> >> git at git.kde.org:projects/extragear/graphics/kst-plot
> >> [cbn at ice kst]$ git push --all origin
> >> FATAL: W any projects/extragear/graphics/kst-plot netterfield DENIED by
> >> fallthru
> >> (or you mis-spelled the reponame)
> >> fatal: Could not read from remote repository.
> >> 
> >> Please make sure you have the correct access rights
> >> and the repository exists.
> >> 
> >> 1 Months Ago netterfield -- 12/4/13, 9:14 PM
> >> As when I first pushed to scratch, I'm getting a commit hook failure
> >> because of line endings for
> >> i) old files that are longer in the project - but are part of the history
> >> ii) files that no longer have the wrong line endings (but did in the
> >> history) iii) binary image (fits) files.
> >> 
> >> Can the commit audit be suspended until I have successfully committed?
> >> 
> >> thanks
> >> Barth
> >> 
> >> 1 Months Ago Administrators -- 12/5/13, 4:51 AM
> >> This has now been done in
> >> http://commits.kde.org/repo-management/09e110b15cf2963b869da1e5bfa2986959
> >> 91
> >> ca92
> >> 
> >> 1 Months Ago netterfield -- 12/5/13, 7:36 PM
> >> kst-plot has been pushed.
> >> Is there a website with instructions on how to make sure everything is
> >> set
> >> up properly for translations, etc?
> >> 
> >> 1 Months Ago Administrators -- 12/5/13, 9:06 PM
> >> Thanks, i've now removed the audit exceptions.
> >> 
> >> In terms of ensuring everything is properly setup, please follow the
> >> instructions given above. If you need further guidance on translations I
> >> suggest you contact the translation co-ordinator, Albert Astals Cid
> >> (tsdgeos on Freenode).
> >> 
> >> Thanks,
> >> Ben
> >> 
> >> 1 Months Ago Administrators -- 12/6/13, 10:39 AM
> >> Please enable the regular commit hooks as well, as noted above in the
> >> repo
> >> creation text.
> >> 
> >> 1 Months Ago netterfield -- 12/7/13, 7:41 PM
> >> 
> >> >> ...once the initial push has been completed....
> >> 
> >> Done
> >> 
> >> >> have filled in the trunk and stable i18n branch information in
> >> >> Settings
> >> >> ->
> >> 
> >> Repository for each project
> >> Done
> >> 
> >> >> Please note that you will need to run the "hooks enable" server-side
> >> 
> >> command after the initial push
> >> Done
> >> 
> >> >> please ensure the repository setting Enable development sites is
> >> >> enabled
> >> >> on
> >> 
> >> KDE Projects in Settings -> Repository
> >> Done
> >> 
> >> 1 Months Ago Administrators -- 12/7/13, 10:48 PM
> >> Excellent, thanks. Everything seems to be sorted out now, so closing this
> >> ticket.
> >> 
> >> Thanks,
> >> Ben