Review Request 114924: Konqueror: fix crash wnen switching between view modes

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114924/#review47101
-----------------------------------------------------------


I guess we tried to fix the same problem. I think my fix is much simpler. See https://git.reviewboard.kde.org/r/114926/

- Dawit Alemayehu


On Jan. 9, 2014, 12:09 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114924/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 12:09 p.m.)
> 
> 
> Review request for KDE Base Apps and Dawit Alemayehu.
> 
> 
> Bugs: 322686
>     http://bugs.kde.org/show_bug.cgi?id=322686
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The referenced bug describes an assert crash which happens when switching view modes in Konqueror, using the View - View Mode menu.  It does not happen when switching view modes via the Dolphin Part toolbar.
> 
> Although the problem does not happen for adawit, this changes fixes the crash for me.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp 8a21c1b 
> 
> Diff: https://git.reviewboard.kde.org/r/114924/diff/
> 
> 
> Testing
> -------
> 
> Built kde-baseapps with these changes.  Checked no crash when switching view mode both by toolbar and menu, and that the correct items in each case are checked.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140109/710a9d35/attachment.htm>