Review Request 110813: Add support for just smooth window movement and resizing to wobbly windows effect

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110813/#review47043
-----------------------------------------------------------


sorry for the late review. It didn't end in my review board inbox :-(

I think it's conceptually wrong to have a no wobble option in an effect which is called wobbly windows. If one doesn't want wobbly windows one can just disable the effect. I understand what you want to achieve but adding it here makes the effect significantly more complex and adds a very obscure feature to the effect. I doubt that any users would find this feature and thus it would be a solution just for your private use case. We try to not go this road.

I thank you for this contribution and hope that you understand my reasoning why I don't want this in wobbly windows. Please excuse again the long time for the review.

- Martin Gräßlin


On June 3, 2013, 9:55 p.m., Stefanos Harhalakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110813/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 9:55 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 319887
>     http://bugs.kde.org/show_bug.cgi?id=319887
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> A patch that adds the ability to the wobbly windows effect not to wobble the window (i.e. not change its shape).
> 
> This results in two things:
> 1) Have a very smooth movement of windows that can be customized
> 2) Have a nice effect when resizing a window (is resizing is enabled)
> 
> It does this by adding the noWobble attribute to the effect and then using that attribute to disable a subset of the functionality. It also adds an additional wobbliness level: shifts levels 0-4 to 1-5 and makes 0 the level without wobbliness.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/wobblywindows/wobblywindows.h 69d1f87 
>   kwin/effects/wobblywindows/wobblywindows.cpp ad1842c 
>   kwin/effects/wobblywindows/wobblywindows_config.ui 0498a64 
> 
> Diff: https://git.reviewboard.kde.org/r/110813/diff/
> 
> 
> Testing
> -------
> 
> I'm running this for the past day without issues.
> 
> 
> Thanks,
> 
> Stefanos Harhalakis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140108/eb544a0f/attachment.htm>