Review Request 101343: remove functions *Command::name() which are not used

Albert Astals Cid aacid at kde.org
Sun Feb 16 17:12:04 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/101343/#review49935
-----------------------------------------------------------


Alexander, did you see David's comment? Do you plan to implement what he suggests?

- Albert Astals Cid


On May 12, 2011, 6:55 a.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/101343/
> -----------------------------------------------------------
> 
> (Updated May 12, 2011, 6:55 a.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> konq-plugins/domtreeviewer builds without there functions.
> 
> May be these functions were left for future integration of domtreeviewer undoable commands' into Konqueror's undo stack. But for now, they only add a few translatable strings the user won't ever see.
> 
> 
> Diffs
> -----
> 
>   konq-plugins/domtreeviewer/domtreecommands.h df8272e 
>   konq-plugins/domtreeviewer/domtreecommands.cpp e4c7fff 
> 
> Diff: https://git.reviewboard.kde.org/r/101343/diff/
> 
> 
> Testing
> -------
> 
> konq-plugins/domtreeviewer compiles after this change.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140216/371c04fb/attachment.htm>


More information about the kde-core-devel mailing list