Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 4 p.m.)


Review request for kdelibs and Andrea Iacovitti.


Changes
-------

Updated the patch because I discovered more issues with the way khtml does its xmlhttp requests.

Andrea please review and see if you have any objections. As stated in my comments, setting a custom HTTP header blindly has unintended consequences. It pretends to correctly redirect a POST request to another POST request for 307/308 HTTP response codes when it really does not. IOW, it simply changes the method from GET to POST, because of the presence of the custom HTTP method, but does NOT send any content to the redirected resource like a real POST->POST redirection should.


Bugs: 331007
    http://bugs.kde.org/show_bug.cgi?id=331007


Repository: kdelibs


Description
-------

Fix khtml/ecma/xmlttprequest.cpp such that it correctly handles HEAD requests without a noticable delay, i.e. use KIO::mimeType instead of KIO::get. Otherwise, the request will wait for the content which is not returned when doing a stat operation like HEAD.


Diffs (updated)
-----

  khtml/ecma/xmlhttprequest.cpp b3707e7 
  kio/kio/job.cpp abb3dfd 

Diff: https://git.reviewboard.kde.org/r/115689/diff/


Testing
-------

Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140214/b9a081aa/attachment.htm>