Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

[Andrea Iacovitti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689/#review49671
-----------------------------------------------------------

Ship it!


Looks good from my side.

I added some comments in https://git.reviewboard.kde.org/r/115651 about http.cpp's changes.

- Andrea Iacovitti


On Feb. 12, 2014, 9:56 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115689/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:56 a.m.)
> 
> 
> Review request for kdelibs and Andrea Iacovitti.
> 
> 
> Bugs: 331007
>     http://bugs.kde.org/show_bug.cgi?id=331007
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Fix khtml/ecma/xmlttprequest.cpp such that it correctly handles HEAD requests without a noticable delay, i.e. use KIO::mimeType instead of KIO::get. Otherwise, the request will wait for the content which is not returned when doing a stat operation like HEAD.
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/xmlhttprequest.cpp b3707e7 
>   kio/DESIGN.metadata 1351119 
>   kio/kio/accessmanager.cpp 7a806e8 
>   kio/kio/job.cpp 13107c2 
>   kioslave/http/http.cpp b13eed1 
> 
> Diff: https://git.reviewboard.kde.org/r/115689/diff/
> 
> 
> Testing
> -------
> 
> Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140212/84e7d6a9/attachment.htm>