Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

[Martin Gräßlin]

> On Feb. 6, 2014, 12:26 p.m., Hugo Pereira Da Costa wrote:
> > @Martin
> > in kstyles/oxygen
> > you are missing oxygenblurhelper (and likely kate will crash when showing a tooltip)
> > 
> > in kwin/clients/oxygen (but might be another review)
> > oxygenclient
> > oxygensizegrip
> > config/oxygendetectwidget
> > 
> > Other than that, ship it !

kwin/clients doesn't matter (yet) ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115515/#review49102
-----------------------------------------------------------


On Feb. 6, 2014, 11:55 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115515/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 11:55 a.m.)
> 
> 
> Review request for kde-workspace and Hugo Pereira Da Costa.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> [oxygen] Check whether we are on platform X11 before calling into xcb
> 
> Just because we compiled with X11 present doesn't mean we run on X11.
> This fixes quite a lot of crashers when trying to run framework apps
> on Wayland.
> 
> @Hugo: do you know of further files which use xcb unconditionally and which I just haven't hit yet?
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/CMakeLists.txt ca9cc1a1710187f5013482ef502c456238fd4373 
>   kstyles/oxygen/oxygenshadowhelper.cpp f77093daa4f907afd55333032c6f6b618ad2f47f 
>   kstyles/oxygen/oxygenstylehelper.cpp 7e2de41822bf0205e2cec7ea82c8e3f6751a2a6b 
>   kstyles/oxygen/oxygenwindowmanager.h 7ef54d3172b0b0a92b6c33152858cb923b9d3f1e 
>   kstyles/oxygen/oxygenwindowmanager.cpp 308ce4d049b6ce4c9c2cdd67448d351747f34b19 
>   libs/oxygen/oxygenhelper.h 8d734e6e3f3a23c0257cc400417c340ba6d48bea 
>   libs/oxygen/oxygenhelper.cpp 1fe78c24c053e74f2179de00ee9a5701997a0acb 
> 
> Diff: https://git.reviewboard.kde.org/r/115515/diff/
> 
> 
> Testing
> -------
> 
> running Kate on Wayland till it crashes (or doesn't)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140206/810450e7/attachment.htm>