<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115515/">https://git.reviewboard.kde.org/r/115515/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2014, 12:26 p.m. CET, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Martin
in kstyles/oxygen
you are missing oxygenblurhelper (and likely kate will crash when showing a tooltip)
in kwin/clients/oxygen (but might be another review)
oxygenclient
oxygensizegrip
config/oxygendetectwidget
Other than that, ship it !</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kwin/clients doesn't matter (yet) ;-)</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 6th, 2014, 11:55 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2014, 11:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[oxygen] Check whether we are on platform X11 before calling into xcb
Just because we compiled with X11 present doesn't mean we run on X11.
This fixes quite a lot of crashers when trying to run framework apps
on Wayland.
@Hugo: do you know of further files which use xcb unconditionally and which I just haven't hit yet?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">running Kate on Wayland till it crashes (or doesn't)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyles/oxygen/CMakeLists.txt <span style="color: grey">(ca9cc1a1710187f5013482ef502c456238fd4373)</span></li>
<li>kstyles/oxygen/oxygenshadowhelper.cpp <span style="color: grey">(f77093daa4f907afd55333032c6f6b618ad2f47f)</span></li>
<li>kstyles/oxygen/oxygenstylehelper.cpp <span style="color: grey">(7e2de41822bf0205e2cec7ea82c8e3f6751a2a6b)</span></li>
<li>kstyles/oxygen/oxygenwindowmanager.h <span style="color: grey">(7ef54d3172b0b0a92b6c33152858cb923b9d3f1e)</span></li>
<li>kstyles/oxygen/oxygenwindowmanager.cpp <span style="color: grey">(308ce4d049b6ce4c9c2cdd67448d351747f34b19)</span></li>
<li>libs/oxygen/oxygenhelper.h <span style="color: grey">(8d734e6e3f3a23c0257cc400417c340ba6d48bea)</span></li>
<li>libs/oxygen/oxygenhelper.cpp <span style="color: grey">(1fe78c24c053e74f2179de00ee9a5701997a0acb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>