KAccounts move into extragear/base

[Martin Klapetek]

On Wed, Dec 10, 2014 at 12:43 AM, Albert Astals Cid <aacid at kde.org> wrote:

>
> I'm missing some documentation in the .h files you install from lib.
>

All .h are now fully documented.


>
> Also it seems
> private Q_SLOTS:
>     void getCredentials();
> could go into the d pointer via the Q_PRIVATE_SLOT magic?
>

Done.


>
> >
> > KAccounts-providers is only a data repository, it contains the various
> XML
> > files needed for some basic accounts like Google and Facebook.
> >
> > Signon-kwallet-extension is a plugin for signond (the upstream daemon) to
> > store secretes in kwallet.
>
> Maybe the construct/destruct qDebugs you can turn into qcDebugs? Or plain
> remove them?
>

Yeah, not too useful. Removed.

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141211/74a3e6eb/attachment.htm>