Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

[Mathieu Tarral]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119701/
-----------------------------------------------------------

Review request for KDE Base Apps.


Repository: kde-baseapps


Description
-------

Fixes display issues of dolphin statusbar widgets when a high DPI value is used (>= 196 for example).

Changes :
- remove setFixedHeight to fix vertical alignement
- changes fixed values in setMaximumWidth from 150 to averageCharWidth of m_label * 15

So, the font width now respects the dpi settings because averageCharWidth will get it's value.
But there is still an hardcoded value (15).

Note : QtCurve seemed to be bugged (see screenshots)


Diffs
-----

  dolphin/src/statusbar/dolphinstatusbar.cpp 169395e 

Diff: https://git.reviewboard.kde.org/r/119701/diff/


Testing
-------

set DPI to 196 (System Settings -> Appearance -> Fonts)
run dolphin
look at widgets width in statusbar


File Attachments
----------------

show bug
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/4261e582-bc57-46d9-af90-17eb393c2348__show-bug.png
fix-cleanlooks
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/a9e58970-8f78-426a-a6db-5c0adbed257a__cleanlooks.png
fix-oxygen
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/03c97f1d-b8b4-401b-84c8-f72d8433ce38__oxygen.png
fix-plastique
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/5b77a1c1-7585-4c66-bb2b-8c49ef5c96cc__plastique.png
fix-qtcurve-agua
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/e5829939-c576-488b-b502-ad36c09fdea8__qtcurve-agua.png
fix-qtcurve-breeze
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/3abc162a-6d77-46cd-ab70-028c601a455c__qtcurve-breeze.png
fix-qtcurve-default
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/c0128193-f326-4bc2-ad49-0f0253adca76__qtcurve-default.png


Thanks,

Mathieu Tarral

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140810/a3659ffa/attachment.htm>