Review Request 119663: libkscreensaver: blank mouse cursor in startup code

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119663/#review64072
-----------------------------------------------------------


Would it be sufficient to set the cursor on "target" instead of an application wide override?

setOverrideCursor has this "nasty" stack behavior which could be troublesome in a library and I could eg. think of "screensavers" implementing a little game (ie. run kpatience or so ;-)
In case they should have nice control over the cursor w/o having to rewind a stack (or using an override on top ...)

- Thomas Lübking


On Aug. 8, 2014, 12:37 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119663/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 12:37 nachm.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 334762
>     http://bugs.kde.org/show_bug.cgi?id=334762
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Qt's QGLWidget apparently explicitely sets a standard mouse pointer for the screensaver widget.
> This patch prevents the mouse cursor from being shown for KDE's OpenGL screensavers by setting a blank override cursor for the screensaver application when not run in demo mode.
> 
> 
> Diffs
> -----
> 
>   kscreensaver/libkscreensaver/main.cpp 561205a 
> 
> Diff: https://git.reviewboard.kde.org/r/119663/diff/
> 
> 
> Testing
> -------
> 
> Set one of KDE's OpenGL screensavers in systemsettings->Display and Monitor->Screen Locker, like Euphoria or Solarwinds.
> Wait for the screensaver to kick in.
> Notice that the mouse pointer is blanked now, whereas it was shown without this patch.
> 
> If a password is required, the mouse cursor does correctly re-appear for the greeter as it should if you move the mouse/press a key to get rid of the screensaver.
> 
> I'm using the patch on my systems for over two months now and haven't noticed any unexpected results.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140808/dca9623e/attachment.htm>