Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

Commit Hook null at kde.org
Wed Apr 16 21:25:06 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/#review55915
-----------------------------------------------------------


This review has been submitted with commit fe8a0f456da5d3827e41c7754362844ebd11af84 by David Jarvie to branch KDE/4.12.

- Commit Hook


On April 14, 2014, 11:48 a.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116951/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 11:48 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdbusservicestarter.cpp 90624fb 
> 
> Diff: https://git.reviewboard.kde.org/r/116951/diff/
> 
> 
> Testing
> -------
> 
> Tested this scenario, and it now returns the error string.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140416/d9e86bd5/attachment.htm>


More information about the kde-core-devel mailing list