Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

David Faure faure at kde.org
Tue Apr 15 18:33:19 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/#review55824
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On April 14, 2014, 11:48 a.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116951/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 11:48 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdbusservicestarter.cpp 90624fb 
> 
> Diff: https://git.reviewboard.kde.org/r/116951/diff/
> 
> 
> Testing
> -------
> 
> Tested this scenario, and it now returns the error string.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140415/592ea533/attachment.htm>


More information about the kde-core-devel mailing list