Review Request 117174: Fix installing and removing desktop plasma theme packages.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117174/#review54754
-----------------------------------------------------------


I'm OK with this last version, except for one whitespace issue, " " before filename, please.

Also, you can update the patch shown in Reviewboard, that makes it way easier to read. Don't just upload a file, but "Update diff" from the top menu instead.

Someone else should have a look over it and ship it, I'll be unavailable in the next days.

- Sebastian Kügler


On April 1, 2014, 12:18 a.m., Andrei Amuraritei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117174/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 12:18 a.m.)
> 
> 
> Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian Monroe.
> 
> 
> Bugs: 149479
>     http://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Even though the bug appears RESOLVED it is not.
> 
> Minor hack to packagestructure.cpp to search for the metadata.desktop file recursively. This helps with installing desktop themes and removing them.
> I have tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore SoftSand for example, it's metadata.desktop is not properly formatted. There are others too which are not formatted which I guess could be fixed by setting a new format standard, maybe even a check package script to check new uploads on kde-look.org.
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1 
> 
> Diff: https://git.reviewboard.kde.org/r/117174/diff/
> 
> 
> Testing
> -------
> 
> Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some themes are broken so they won't work (not install).
> 
> 
> File Attachments
> ----------------
> 
> Limit the extra search to first subdirectory.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/c9b4a3ee-bd3b-498a-b18c-a4eb13b349d3__0002-Limit-the-search-to-include-the-first-directory-only.patch
> 
> 
> Thanks,
> 
> Andrei Amuraritei
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140401/047f6a8c/attachment.htm>