Review Request 117174: Fix installing and removing desktop plasma theme packages.

Andrei Amuraritei sirdeiu at bydeiu.net
Tue Apr 1 01:18:10 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117174/
-----------------------------------------------------------

(Updated April 1, 2014, 12:18 a.m.)


Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian Monroe.


Changes
-------

So I've modified it to search for the metadata.desktop file in the first subdirectory only.


Bugs: 149479
    http://bugs.kde.org/show_bug.cgi?id=149479


Repository: kdelibs


Description
-------

Even though the bug appears RESOLVED it is not.

Minor hack to packagestructure.cpp to search for the metadata.desktop file recursively. This helps with installing desktop themes and removing them.
I have tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore SoftSand for example, it's metadata.desktop is not properly formatted. There are others too which are not formatted which I guess could be fixed by setting a new format standard, maybe even a check package script to check new uploads on kde-look.org.


Diffs
-----

  plasma/packagestructure.cpp 71148e1 

Diff: https://git.reviewboard.kde.org/r/117174/diff/


Testing
-------

Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some themes are broken so they won't work (not install).


File Attachments (updated)
----------------

Limit the extra search to first subdirectory.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/c9b4a3ee-bd3b-498a-b18c-a4eb13b349d3__0002-Limit-the-search-to-include-the-first-directory-only.patch


Thanks,

Andrei Amuraritei

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140401/144c76d4/attachment.htm>


More information about the kde-core-devel mailing list