Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112848/#review41014
-----------------------------------------------------------



kdeui/tests/kbuttongrouptest.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30108>

    Inconsistent spaces inside the parenthesis.
    
    My suggestion: ignore the current coding style of this file and apply kdelibs coding style to new code: no space between parenthesis (this applies to the QCOMPARE calls in the previous method too)



kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30107>

    This change isn't needed. <QChildEvent> is just fine.
    
    The mandatory QtCore/ prefix is only for public headers, in Qt4/kde4 (and dropped in Qt5/KF5). This isn't a header file, in any case.



kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30109>

    while you're reindenting, you should also remove all spaces within parenthesis.


- David Faure


On Sept. 20, 2013, 7:23 p.m., Bruno Farias wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112848/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 7:23 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> - Adding new test for kbuttongroup
> - Fixing kbuttongroup.cpp identation
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/kbuttongrouptest.h cd9130a9b0840160bdce5a1841735e2050d10a7d 
>   kdeui/tests/kbuttongrouptest.cpp d5f9f88b839d4be88cac81c1e7d0444422dd17ea 
>   kdeui/widgets/kbuttongroup.cpp 4057cc023107cd76cc34590f4b1dd91e01717d3d 
> 
> Diff: http://git.reviewboard.kde.org/r/112848/diff/
> 
> 
> Testing
> -------
> 
> All tests of KButtonGroupTest were passed
> 
> 
> Thanks,
> 
> Bruno Farias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130930/302e587a/attachment.htm>