Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112848/#review40908
-----------------------------------------------------------


Not a thorough review, but some comments inline anyway.


kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30051>

    no spaces around the parentheses



kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30052>

    If you're doing formatting changes, please submit them in a separate patch.
    
    It's not so much of an issue here, but makes it easier to review.



kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30053>

    no spaces within parentheses:
    
    if (event->removed()) {
    
    


- Sebastian Kügler


On Sept. 20, 2013, 7:23 p.m., Bruno Farias wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112848/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 7:23 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> - Adding new test for kbuttongroup
> - Fixing kbuttongroup.cpp identation
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/kbuttongrouptest.h cd9130a9b0840160bdce5a1841735e2050d10a7d 
>   kdeui/tests/kbuttongrouptest.cpp d5f9f88b839d4be88cac81c1e7d0444422dd17ea 
>   kdeui/widgets/kbuttongroup.cpp 4057cc023107cd76cc34590f4b1dd91e01717d3d 
> 
> Diff: http://git.reviewboard.kde.org/r/112848/diff/
> 
> 
> Testing
> -------
> 
> All tests of KButtonGroupTest were passed
> 
> 
> Thanks,
> 
> Bruno Farias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130927/3eb79e85/attachment.htm>